-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWSSDK.Extensions.NETCore.Setup 3.7.2 causing tests to be extremely slow #2000
Comments
Hi @dannystommen, Good afternoon. Would it be possible to share a sample code solution containing tests that target 3.7.1 and 3.7.2 respectively, in order for us to investigate the issue? Thanks, |
may be link to #1996 |
@Scorpio59 The other issue doesn't appear to be related since user was getting different execution times due to way credentials were configured. |
@ashishdhingra I managed to create a sample. Can I sent you this via a DM/email instead of sharing the sample here? I stripped down one of our production projects, which I can not share here publically. |
@dannystommen We need to come up with the minimal reproducible sample to investigate the issue (reference https://stackoverflow.com/help/minimal-reproducible-example). May be just a test case having issue! |
@ashishdhingra I managed to make it minimal, find attached the zip file, with 1 single test in it. I also managed to find the "cause". Removing line 11-15 in the test-aws-sdk-extensions-setup.zip Let me know if this is suffiecient, or need anything als from my end. |
@dannystommen Can you describe your pipeline setup? Is it AWS CodeBuild or something else and how are credentials expected to be retrieved for the service clients? |
It's running in gitlab. If you commit this code to a gitlab repo, it will automatically run the pipeline (gitlab-ci.yml is included). Not sure what you mean with "how are credentials expected to be retrieved". |
@ashishdhingra any updates on this? |
Just ran into this issue on a brand new project. 30s to create a client through |
I was able to fix it what that solution. Add this to your .json, of course merge it within a current AWS block where applicable without including the additional block. "AWS": { |
I'm going to resolve this as it seems to be the same issue as #2022. I haven't been able to reproduce using the latest version of the extensions package, but we'll take a look if the problem still exists. FYI: I tried running your |
Comments on closed issues are hard for our team to see. |
Description
we're using AWSSDK.Extensions.NETCore.Setup and since updating it to 3.7.2, running tests became extremely slow in our pipeline. On my local (windows) machine, everything still works as expected. In our pipeline, total time of tests increased from 5 seconds to 130 sec.
Find attached the test results
When looking at all tests, multiple tests take 16 seconds suddenly, like something is being locked. Some tests even take 32 sec. Nothing in between. So a lots of tests complete in milliseconds, a few tests take like 16 sec, and 1 or 2 tests take 32 sec.
Environment
dotnet test --configuration Release --filter Category=Unit --test-adapter-path:. --logger:"junit;LogFilePath=..\artifacts\{assembly}-unit-test-result.xml;MethodFormat=Class;FailureBodyFormat=Verbose"
This is a 🐛 bug-report
test-results.zip
The text was updated successfully, but these errors were encountered: