Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authenticator] User can maybe see an empty verification attribute screen #128

Closed
2 tasks done
mattcreaser opened this issue Mar 21, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
authenticator This issue relates to the Authenticator component bug Something isn't working

Comments

@mattcreaser
Copy link
Member

Before creating a new issue, please confirm:

Which UI component?

Authenticator

Gradle script dependencies

// Put output below this line

Environment information

# Put output below this line


Please include any relevant guides or documentation you're referencing

No response

Describe the bug

If the configuration file contains one verification mechanism and a user doesn't have a matching attribute for that mechanism, we still show the attribute verification screen, but the list is empty.

It's unclear if this is a valid scenario - I tried updating my Cognito console to require a different verification mechanism but my amplifyconfiguration.json did not change on amplify pull. Although it's not clear whether a user can actually get into this situation, we should still guard against this possibility.

This can be fixed by adding a condition for verificationAttributes.isEmpty() here.

Screenshot_20240321_114820

Reproduction steps (if applicable)

  1. Setup Cognito with Email as a verification attribute and don't make phone numbers required.
  2. Create a user.
  3. Change verificationMechanisms in amplifyconfiguration.json to be "SMS".
  4. Log in as that user.

Code Snippet

// Put your code below this line.

Log output

// Put your logs below this line


amplifyconfiguration.json

No response

Additional information and screenshots

No response

@mattcreaser mattcreaser added bug Something isn't working authenticator This issue relates to the Authenticator component labels Mar 21, 2024
@github-actions github-actions bot added pending-triage Issue is pending triage and removed pending-triage Issue is pending triage labels Mar 21, 2024
@mattcreaser mattcreaser self-assigned this Apr 19, 2024
@mattcreaser mattcreaser added the pending-release This issue has been fixed and will be included in a future release label Apr 26, 2024
@mattcreaser
Copy link
Member Author

This was released in Authenticator 1.2.0

@github-actions github-actions bot removed the pending-release This issue has been fixed and will be included in a future release label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authenticator This issue relates to the Authenticator component bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant