-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw when loading a TypeScript file that is not covered by the rewrite paths #26
Comments
Oh this is interesting! It works… because This line stops the TypeProvider from being the one to load the test file: Line 118 in 058b5be
I think maybe Line 128 in 058b5be
And then we can state that all selected TypeScript test files must be covered by the rewrite paths. What do you think @vedantroy? |
I think that's a good idea! Doing extra checks is preferable to letting things work by accident I would try submitting a PR for this, but unfortunately I'm a bit busy at the moment. |
This is more like an anti-bug than an actual bug. But it seems like this project works even when I provide a nonsensical rewritePaths entry, for example:
Shouldn't ava crash if this occurs?
Here's the repository ("ava" branch): https://github.com/vedantroy/typecheck.macro
Check out the repository, switch to the ava branch, and then run
npm i && npm run test
.What happens The tests run successfully. You can show that ava is not using the js file by renaming
temp_build/test.js
totemp_build/foobar.js
and then executingnpm run test:run
. The tests will still execute. You can even modifytests/test.ts
, maybe add an extraconsole.log
statement, then runnpm run test:run
, and the new output will be printed. Does ava now support typescript natively, or am I missing something?What you expected to happen: Ava should crash or something because inside of my package.json, I have a meaningless typescript configuration.
Ava version: 3.7.1
The text was updated successfully, but these errors were encountered: