This repository has been archived by the owner on Aug 8, 2020. It is now read-only.

Auto-detect CI and use PhantomJS instead of defined browsers #3

Open

sindresorhus opened this issue Jun 29, 2016 · 1 comment

Labels

Member

sindresorhus commented Jun 29, 2016

Only if karma-phantomjs-launcher is a devDependency of course.

From https://github.com/sindresorhus/any-observable/pull/16/files#r68935463

The text was updated successfully, but these errors were encountered:

sindresorhus added the enhancement label

Contributor

jamestalmage commented Jun 29, 2016

You can get Firefox to work on Travis, so I don't think we should just overwrite the browsers field.

I think it would be better to just allow them to leave the browser field blank, then automatically pick the browsers it should run on:

OSX: Safari, Chrome, Firefox
Windows: IE, Edge, Chrome
CI: PhantomJS (Maybe Firefox if it's installed, and xvfb is running?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.