Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional NativeTokenDestination E2E tests #73

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Conversation

cam-schultz
Copy link
Collaborator

Why this should be merged

  • Partially fixes Additional e2e tests #59
  • Renames some E2E test files and to follow the format <BRIDGETYPE>Source<BRIDGETYPE>Destination with the optional Multihop suffix.
  • Implements the following E2E tests:
    • ERC20 source -> Native destination
    • ERC20 source -> Native destinations multihop

How this works

How this was tested

CI

How is this documented

N/A

@cam-schultz cam-schultz marked this pull request as draft April 10, 2024 14:29
Base automatically changed from gstuart/native-token-destination to main April 10, 2024 16:47
@cam-schultz cam-schultz marked this pull request as ready for review April 10, 2024 17:02
@cam-schultz cam-schultz mentioned this pull request Apr 10, 2024
15 tasks
tests/utils/utils.go Outdated Show resolved Hide resolved
tests/utils/utils.go Outdated Show resolved Hide resolved
tests/utils/utils.go Outdated Show resolved Hide resolved
tests/flows/retry_failed_multihop.go Outdated Show resolved Hide resolved
tests/flows/native_source_native_destination_multihop.go Outdated Show resolved Hide resolved
@geoff-vball
Copy link
Contributor

Also, could you update the branch with the snyk changes?

@@ -13,9 +13,10 @@ import (
)

/**
* Deploy a ERC20 token source on the primary network
* Deploy a b ative token source on the primary network
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

tests/utils/utils.go Outdated Show resolved Hide resolved
@michaelkaplan13 michaelkaplan13 merged commit 946ba53 into main Apr 12, 2024
13 checks passed
@michaelkaplan13 michaelkaplan13 deleted the more-e2e-tests branch April 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Additional e2e tests
3 participants