Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for typescript pre-release peer dependencies #18

Open
TimvdLippe opened this issue May 25, 2021 · 4 comments
Open

Allow for typescript pre-release peer dependencies #18

TimvdLippe opened this issue May 25, 2021 · 4 comments

Comments

@TimvdLippe
Copy link

In Chrome DevTools, we tend to use beta/release candidates of TypeScript to catch errors early. Currently, we are depending on 4.3.1-rc. However, if we install rollup-plugin-minify-html-template-literals (which has a transitive dependency on this package), we now get a duplicate installation of TypeScript.

This behavior is sadly intentional by npm, as semver doesn't think that 4.3.1-rc matches ^4.0.0. Based on https://survivejs.com/maintenance/packaging/managing-dependencies/#understanding-version-ranges I think it should be possible to update the ^4.0.0 range to ^4.0.0-0 to also include beta releases of any TypeScript 4.x version.

Could we update the dependency version of typescript in this package to include pre-releases of TypeScript 4.x?

@asyncLiz
Copy link
Owner

I don't see a problem with that. D'you mind sending in a PR?

@TimvdLippe
Copy link
Author

Urgh that doesn't appear to work 😭 I don't know any workarounds sadly.

@TimvdLippe
Copy link
Author

I asked the question here: https://twitter.com/TimvdLippe/status/1397509326554738690 Let's hope anybody else knows how to do this.

@TimvdLippe
Copy link
Author

I ended up filing microsoft/TypeScript#44297 so hopefully we can resolve it in TypeScript land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants