Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axsdist units are unclear #17

Open
ctslater opened this issue Jan 2, 2020 · 3 comments
Open

axsdist units are unclear #17

ctslater opened this issue Jan 2, 2020 · 3 comments

Comments

@ctslater
Copy link
Member

ctslater commented Jan 2, 2020

Ernesto Castillo asks a very good question: what are the units on axsdist? This seems to be computed by calcGnom in FrameFunctions.scala, but I can't follow what the final formula is producing.

@Dav-v
Copy link

Dav-v commented May 15, 2020

Hi, are there any updates on this? Looking at the functions calcGnom() and degToGnom() and the conversion gnom_dist = degToGnom(r) ( gnom_dist = tan(rad(r)) ), could this be a gnomonic projection? Is there something in the documentation or in other external sources that explains the method and the formulas used to determine the distance?

@zecevicp
Copy link
Collaborator

zecevicp commented May 21, 2020

If we take the Gnomonic projection equations and set phi_1 and lambda_0 both to zero, (and also substitute lambda for abs(ra_2-ra_1) and phi for abs(dec_2-dec_1)), that would be as though the projection is centered on ra_1 and dec_1. That's what was implemented. I hope that makes sense for you?

@Dav-v
Copy link

Dav-v commented May 25, 2020

Yes, thank you very much @zecevicp . I was also wondering, is there a particular reason why the UDFs are written in Scala? Wouldn't be possible to implement calcGnom() directly in Python as a PandasUDF or using the built-in SQL functions? Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants