Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram2d doesn't exclude out-of-bounds entries #12

Open
ctslater opened this issue Oct 4, 2019 · 1 comment
Open

histogram2d doesn't exclude out-of-bounds entries #12

ctslater opened this issue Oct 4, 2019 · 1 comment

Comments

@ctslater
Copy link
Member

ctslater commented Oct 4, 2019

If the dataframe has values outside the min1, max1, etc bounds, histogram2d will try to put these values into the output array but that will result in out-of-bounds errors.

@ctslater
Copy link
Member Author

ctslater commented Oct 4, 2019

I've pushed a branch issue12_histogram which fixes this and switches to using integers for bins. There were some weird effects where certain columns or rows had all zeros, I'm guessing due to some rounding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant