Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup of preconditions in FSM test using previous states directly #46

Open
David-Estevez opened this issue May 12, 2016 · 2 comments

Comments

@David-Estevez
Copy link
Collaborator

As it is done in testGameState, all preconditions can be setup by using previous states code directly. This is error-proof, as the previous states are also covered by unit tests.

This is done in testGameState this way, and could be done in testDeadState in a similar way.

@PeterBowman
Copy link
Member

@David-Estevez could you take a look here and check whether this issue has been resolved since then? The snapshot of the unit tests directory at the time of opening this is: https://github.com/asrob-uc3m/robotDevastation/tree/8eb14b2/test.

@David-Estevez
Copy link
Collaborator Author

Checking testDeadState.cpp, lines 139-146:

//-- Finish setup of the modules that start at game state:
//-- Note: we can change this to use GameState (as previously) if we want someday
mockupImageManager->start();
listener = new MockupInputEventListener;
mockupInputManager->addInputEventListener(listener);
audioManager->start();
audioManager->play("RD_THEME", -1);
mockupRobotManager->setEnabled(true);

it seems that this has not been solved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants