Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README for part #1 of the R1CS Tutorial is misguiding #11

Open
fwmm opened this issue May 31, 2023 · 1 comment
Open

README for part #1 of the R1CS Tutorial is misguiding #11

fwmm opened this issue May 31, 2023 · 1 comment

Comments

@fwmm
Copy link

fwmm commented May 31, 2023

∂

Summary of Bug

The README for the merkle tree example in the R1CS tutorial incorrectly states that it will show how to invoke a SNARK when actually the example is only about generating the constraints and verifying satisfiability directly using the witness input itself. This is confusing for beginners trying to learn arkworks.

Version

commit 5d3a902

Steps to Reproduce

Compare the README to the example code.
@neocarmack
Copy link

yes. The example is simply filling the merkle path to verify, it is not a construction of r1cs. The knowledge is exposed, not a zero knowledge proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neocarmack @fwmm