Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run e2e tests on pull_request #50

Closed

Conversation

samuelburnham
Copy link
Member

Simplifies end2end CI to run on pull_request rather than issue_comment, i.e. the integration tests will automatically run on every PR commit rather than when !test is commented by a maintainer. This will decrease maintenance overhead while preserving security since we now use Buildjet and require approval to run CI.

Also fixes an issue where the issue_comment workflow wouldn't trigger the required status check, which seems to be an inherent GitHub Actions limitation.

Note

This should also be merged to the other feature branches for consistency.

@samuelburnham samuelburnham marked this pull request as draft February 7, 2024 02:31
@samuelburnham
Copy link
Member Author

Closing as I forgot the pull_request trigger doesn't allow access to secrets 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant