Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiStorage read/write operations ignore return value from WiFiDrv #242

Open
mikaelj opened this issue Mar 20, 2023 · 0 comments
Open

WiFiStorage read/write operations ignore return value from WiFiDrv #242

mikaelj opened this issue Mar 20, 2023 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@mikaelj
Copy link

mikaelj commented Mar 20, 2023 •
edited by per1234
Loading

....making it impossible to know if the operation was successful or not.

e.g. WifiStorage.write():

WiFiNINA/src/WiFiStorage.h

Line 53 in 0e7e65b

static bool write(const char *filename, uint32_t offset, uint8_t* buffer, uint32_t buffer_len) {

What's the recommended way of catching write errors?

Also, return type is int8_t while buffer_len is uint32_t.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikaelj @per1234