Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): standardize release process #203

Open
shahbazn opened this issue Jul 28, 2022 · 0 comments
Open

feat(release): standardize release process #203

shahbazn opened this issue Jul 28, 2022 · 0 comments
Labels

Comments

@shahbazn
Copy link
Contributor

shahbazn commented Jul 28, 2022

The following release channels must produce exactly the same build of archway:

Currently above channels produce different result which prevents adding new nodes to constantine network if the binary being used is created with make install:

1:00PM INF minted coins from module account amount=224259267552uconst from=mint module=x/bank
panic: UnmarshalJSON cannot decode empty bytes

Steps to reproduce:

  1. clone archway repo
  2. checkout tag v0.0.5
  3. run make install to install the binary
  4. Add genesis file and peers from constantine network
  5. Download latest data snapshot
  6. Start the node
goroutine 58 [running]:
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.Get({{0x20a98e0, 0xc000fb3460}, 0xc00012b080, {0x208b338, 0xc000c576d0}, {0x208b388, 0xc000c57780}, {0xc000fe1ef0, 0xa, 0x2c}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/params/types/subspace.go:109 +0x307
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.GetParamSet({{0x20a98e0, 0xc000fb3460}, 0xc00012b080, {0x208b338, 0xc000c576d0}, {0x208b388, 0xc000c57780}, {0xc000fe1ef0, 0xa, 0x2c}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/params/types/subspace.go:222 +0x145
github.com/archway-network/archway/x/gastracker/keeper.Keeper.GetParams(...)
	github.com/archway-network/archway/x/gastracker/keeper/params.go:10
github.com/archway-network/archway/x/gastracker/mintbankkeeper.Keeper.SendCoinsFromModuleToModule({{_, _}, {_, _}}, {{0x209e438, 0xc000130020}, {0x20aaf80, 0xc002b7db40}, {{0xb, 0x0}, ...}, ...}, ...)
	github.com/archway-network/archway/x/gastracker/mintbankkeeper/keeper.go:45 +0x175
github.com/cosmos/cosmos-sdk/x/mint/keeper.Keeper.AddCollectedFees(...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/mint/keeper/keeper.go:109
github.com/cosmos/cosmos-sdk/x/mint.BeginBlocker({{0x209e438, 0xc000130020}, {0x20aaf80, 0xc002b7db40}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, {0x2ad83903, ...}, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/mint/abci.go:37 +0x693
github.com/cosmos/cosmos-sdk/x/mint.AppModule.BeginBlock(...)
	github.com/cosmos/cosmos-sdk@v0.45.1/x/mint/module.go:152
github.com/cosmos/cosmos-sdk/types/module.(*Manager).BeginBlock(_, {{0x209e438, 0xc000130020}, {0x20aaf80, 0xc002b7db40}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, ...}, ...}, ...)
	github.com/cosmos/cosmos-sdk@v0.45.1/types/module/module.go:479 +0x3a2
github.com/archway-network/archway/app.(*ArchwayApp).BeginBlocker(_, {{0x209e438, 0xc000130020}, {0x20aaf80, 0xc002b7db40}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, ...}, ...}, ...)
	github.com/archway-network/archway/app/app.go:709 +0x85
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).BeginBlock(_, {{0xc001bcfae0, 0x20, 0x20}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, {0x2ad83903, ...}, ...}, ...})
	github.com/cosmos/cosmos-sdk@v0.45.1/baseapp/abci.go:194 +0x97c
github.com/tendermint/tendermint/abci/client.(*localClient).BeginBlockSync(_, {{0xc001bcfae0, 0x20, 0x20}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, {0x2ad83903, ...}, ...}, ...})
	github.com/tendermint/tendermint@v0.34.16/abci/client/local_client.go:280 +0x118
github.com/tendermint/tendermint/proxy.(*appConnConsensus).BeginBlockSync(_, {{0xc001bcfae0, 0x20, 0x20}, {{0xb, 0x0}, {0xc0028e6200, 0xd}, 0x6a691, {0x2ad83903, ...}, ...}, ...})
	github.com/tendermint/tendermint@v0.34.16/proxy/app_conn.go:81 +0x55
github.com/tendermint/tendermint/state.execBlockOnProxyApp({0x209f468?, 0xc0022b3bc0}, {0x20a4a70, 0xc00005d8a0}, 0xc002b561e0, {0x20aa210, 0xc00047d4b0}, 0x6a690?)
	github.com/tendermint/tendermint@v0.34.16/state/execution.go:307 +0x3dd
github.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(_, {{{0xb, 0x0}, {0xc000d56e80, 0x7}}, {0xc000d56e90, 0xd}, 0x1, 0x6a690, {{0xc004842900, ...}, ...}, ...}, ...)
	github.com/tendermint/tendermint@v0.34.16/state/execution.go:140 +0x171
github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).poolRoutine(0xc0000a5dc0, 0x0)
	github.com/tendermint/tendermint@v0.34.16/blockchain/v0/reactor.go:398 +0xb5a
created by github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).OnStart
	github.com/tendermint/tendermint@v0.34.16/blockchain/v0/reactor.go:110 +0x7a

┆Issue is synchronized with this Jira Task by Unito

@edjroz edjroz added the infrastructure Infrastrucure/DevOps problems with ownership under NetX team label Aug 10, 2022
@shahbazn shahbazn self-assigned this Dec 8, 2022
@shahbazn shahbazn changed the title Standardize build and release feat(release): standardize release process Dec 12, 2022
@shahbazn shahbazn removed their assignment Dec 12, 2022
@shahbazn shahbazn added mainnet and removed infrastructure Infrastrucure/DevOps problems with ownership under NetX team labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants