Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apollo不同表的的相同业务含义的字段长度不一致 #5259

Open
youngzil opened this issue Oct 22, 2024 · 3 comments · May be fixed by #5263
Open

Apollo不同表的的相同业务含义的字段长度不一致 #5259

youngzil opened this issue Oct 22, 2024 · 3 comments · May be fixed by #5263

Comments

@youngzil
Copy link
Contributor

你的特性请求和某个问题有关吗？请描述

在实际使用时，发现日志经常会有少量的数据库字段超长的报错，发现是Release表的NamespaceName字段是 varchar(500)，但是InstanceConfig表的ConfigNamespaceName字段是 varchar(32)

  1. 比如NamespaceName，在AppNamespace表中Name 字段是varchar(32)
  2. 比如Cluster字段，Cluster表中Name字段是 varchar(32)，Commit表中ClusterName字段是 varchar(500)

相同含义的字段在所有表中是否有必要同一，避免一些潜在的问题

清晰简洁地描述一下你希望的解决方案

清晰简洁地描述一下这个特性的备选方案

其它背景

在这里添加和这个特性请求有关的背景说明、截图
@youngzil youngzil changed the title Apollo不同表的的相同业务含义的字段长度不一致，最好统一 Apollo不同表的的相同业务含义的字段长度不一致 Oct 22, 2024
@youngzil
Copy link
Contributor Author

I saw that there was a PR #4725 that made some optimizations for the field length unification, but it did not include the three tables commit, namespace, and release. Why is this?

@nobodyiam
Copy link
Member

It includes the commit, namespace, and release tables but appears to miss the NamespaceName and ClusterName fields.

@youngzil
Copy link
Contributor Author

It includes the commit, namespace, and release tables but appears to miss the NamespaceName and ClusterName fields.

I think this can be fixed and is safe.

@youngzil youngzil linked a pull request Oct 27, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(sql): align database ClusterName and NamespaceName fields lengths youngzil/apollo
2 participants
@nobodyiam @youngzil