Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build config-manager container NPE #8335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: build config-manager container NPE #8335

wants to merge 2 commits into from
+66 −6

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt requested a review from a team as a code owner October 25, 2024 06:49
@sophon-zt sophon-zt linked an issue Oct 25, 2024 that may be closed by this pull request
[BUG] build config-manager container NPE #8333
Open
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (9e28574) to head (ae56a60).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8335      +/-   ##
==========================================
- Coverage   61.30%   61.18%   -0.12%     
==========================================
  Files         350      350              
  Lines       41225    41227       +2     
==========================================
- Hits        25271    25224      -47     
- Misses      13667    13728      +61     
+ Partials     2287     2275      -12
Flag Coverage Δ
unittests 61.18% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zjx20
zjx20 approved these changes Oct 25, 2024
View reviewed changes
pkg/controller/configuration/operator_test.go Outdated
ToolConfigs: []appsv1beta1.ToolConfig{
{
Name: "tools_name",
AsContainerImage: func() *bool { var b = true; return &b }(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https://pkg.go.dev/k8s.io/utils/pointer or https://pkg.go.dev/k8s.io/utils/ptr.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 25, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] build config-manager container NPE
3 participants
@sophon-zt @zjx20 @apecloud-bot