Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMN Editor: Render evaluation highlights in the Boxed Expression Editor (Decision Tables + Boxed Conditional Expressions) #1547

Open
jomarko opened this issue Oct 18, 2024 · 0 comments · May be fixed by apache/incubator-kie-tools#2681
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:enhancement Something that already exists needs to be improved

Comments

@jomarko
Copy link

jomarko commented Oct 18, 2024

This issue is another part related to #1527

We should extend the functionality of the boxed-expression-component to be able to highlight evaluation hit count in the Decision Table and Boxed Conditional Expression using the evaluation results of DMN Runner. Disabling the "Evaluation Highlights" (#1527) must normally render the Boxed Expression Editor.

Figure 1 shows a Decision Table that had multiple rule hits and is highlighted in a purple color (rgb(215 201 255)). The number of hits is represented in the top left corner of the index row with a triangular badge. Rules that didn't have a hit must appear dimmed, with a grayscale and reduced opacity. In the case of the DMN Runner table, hovering the mouse on top of the badge must render the responsible input rows as illustrated.

image-2024-10-09-19-36-47-350

Figure 2 shows a Boxed Conditional Expression with the "then" expression highlighted, and the "else" expression dimmed. This example follows the same changes of the Decision Table highlights.

image-2024-10-09-19-40-48-918

Figure 3 shows an example with nested expressions and a high number of hits. When the number of hits gets higher, the font size gets lower to accommodate the value inside the badge. The expression header inside the condition is highlighted to show the user that the entire expression is part of the condition.
image-2024-10-09-19-44-01-162

@jomarko jomarko added type:enhancement Something that already exists needs to be improved area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects labels Oct 18, 2024
@jomarko jomarko changed the title Render evaluation highlights in the Boxed Expression Editor (Decision Tables + Boxed Conditional Expressions) DMN Editor: Render evaluation highlights in the Boxed Expression Editor (Decision Tables + Boxed Conditional Expressions) Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:enhancement Something that already exists needs to be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant