Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Failed to checkout Git submodules in CI Build C task #4836

Closed
3 tasks done
Pil0tXia opened this issue Apr 14, 2024 · 1 comment · Fixed by #4743
Closed
3 tasks done

[Bug] Failed to checkout Git submodules in CI Build C task #4836

Pil0tXia opened this issue Apr 14, 2024 · 1 comment · Fixed by #4743
Labels
bug Something isn't working Stale

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 14, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Linux

EventMesh version

Other

What happened

In the previous PR #4543, the CI failed due to the inability to clone the submodule and abandoned the execution of the Build C task.

According to this suggestion, the CI is now able to execute the makefile but encountered an error during the compilation process, which is recorded at #4742.

Considering compile error and CI workflow file design oversight are two seperate subject, the original compile error issue #4742 will be remained to track compile error, and this issue is created for #4743 to address CI workflow file design oversight.

After #4742 is fixed, cpp option should be added in jobs.build.strategy.matrix.language array of ci.yml.

How to reproduce

Checkout submodules in CI

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Jul 13, 2024
harshithasudhakar pushed a commit that referenced this issue Oct 21, 2024
#4743)

* checkout submodules

* remove possible redundant "check out git submodule"

* minor naming unification (inrelevant with PR subject)

* Not triggering C task for now

* Use the same version of actions/checkout as 'Build' task for 'License Check' task

* Revert change to avoid conflict

* Update a renamed label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant