Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add const and & to arrow::Array::statistics() return type #44590

Closed
kou opened this issue Oct 31, 2024 · 1 comment
Closed

[C++] Add const and & to arrow::Array::statistics() return type #44590

kou opened this issue Oct 31, 2024 · 1 comment
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
19.0.0

Comments

@kou
Copy link
Member

kou commented Oct 31, 2024

Describe the enhancement requested

The arrow::ArrayStatistics associated in an array must be immutable.

See also: #43801 (comment)

Component(s)

C++
@kou kou mentioned this issue Oct 31, 2024
Merged
kou added a commit to kou/arrow that referenced this issue Oct 31, 2024
@kou
apacheGH-44590: [C++] Add const and & to `arrow::Array::statistic…
7b9cf14 
…s()` return type
@github-actions github-actions bot mentioned this issue Oct 31, 2024
Merged
kou added a commit that referenced this issue Oct 31, 2024
@kou
GH-44590: [C++] Add const and & to arrow::Array::statistics() r…
e1fa7e5 
…eturn type (#44592)

### Rationale for this change

It must be immutable.

### What changes are included in this PR?

Add missing `const` and `&`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

**This PR includes breaking changes to public APIs.**
* GitHub Issue: #44590

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 19.0.0 milestone Oct 31, 2024
@kou
Copy link
Member Author

kou commented Oct 31, 2024

Issue resolved by pull request 44592
#44592

@kou kou closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
1 participant
@kou