Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add ChunkResolver::ResolveMany() API #41560

Closed
felipecrv opened this issue May 6, 2024 · 1 comment
Closed

[C++] Add ChunkResolver::ResolveMany() API #41560

felipecrv opened this issue May 6, 2024 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
17.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

Resolving multiple logical indices in a loop and writing the results to a contiguous buffer allows for vectorization and simplifies the work in supporting ChunkedArray directly in the Take kernel.

Component(s)

C++
@github-actions github-actions bot mentioned this issue May 6, 2024
Merged
felipecrv added a commit that referenced this issue May 15, 2024
@felipecrv
GH-41560: [C++] ChunkResolver: Implement ResolveMany and add unit tes…
e04f5b4 
…ts (#41561)

### Rationale for this change

I want `ResolveMany` to support me in the implementation of `Take` that doesn't `Concatenate` all the chunks from a `ChunkedArray` `values` parameter.

### What changes are included in this PR?

 - Implementation of `ChunkResolver::ResolveMany()`
 - Addition of missing unit tests for `ChunkResolver`

### Are these changes tested?

Yes. By new unit tests.

### Are there any user-facing changes?

No. `ChunkResolver` is an internal API at the moment (see #34535 for future plans).
* GitHub Issue: #41560

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv added this to the 17.0.0 milestone May 15, 2024
@felipecrv
Copy link
Contributor Author

Issue resolved by pull request 41561
#41561

vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@felipecrv @vibhatha
apacheGH-41560: [C++] ChunkResolver: Implement ResolveMany and add un…
3107f2b 
…it tests (apache#41561)

### Rationale for this change

I want `ResolveMany` to support me in the implementation of `Take` that doesn't `Concatenate` all the chunks from a `ChunkedArray` `values` parameter.

### What changes are included in this PR?

 - Implementation of `ChunkResolver::ResolveMany()`
 - Addition of missing unit tests for `ChunkResolver`

### Are these changes tested?

Yes. By new unit tests.

### Are there any user-facing changes?

No. `ChunkResolver` is an internal API at the moment (see apache#34535 for future plans).
* GitHub Issue: apache#41560

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@felipecrv