Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use reflection if auto wiring is not enabled #9

Open
kpicaza opened this issue Aug 29, 2020 · 0 comments
Open

Do not use reflection if auto wiring is not enabled #9

kpicaza opened this issue Aug 29, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kpicaza
Copy link
Member

kpicaza commented Aug 29, 2020

Is your feature request related to a problem? Please describe.
when the auto wiring option is disabled, the container resolves automatically the factory class for the given service, this is unexpected behavior and a performance killer.

Describe the solution you'd like
there should be two options, first set the factory class as a dependency in the container, and the second option is to instantiate dynamically the factory class(assuming that it doesn't have any constructor parameters)

@kpicaza kpicaza added the bug Something isn't working label Aug 29, 2020
@kpicaza kpicaza self-assigned this Aug 29, 2020
@kpicaza kpicaza changed the title Do not use reflection if autowired is not enabled Do not use reflection if auto wiring is not enabled Aug 29, 2020
@kpicaza kpicaza added this to the 1.0.0 milestone Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant