Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating vscode-extension-tester to 8.4.0 and the vscode version used during testing breaks tests #1464

Open
ssbarnea opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link
Member

Seen on https://github.com/ansible/vscode-ansible/actions/runs/10160587251/job/28097290030?pr=1462#step:12:422 which updated

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".monaco-workbench"}

This is very unlikely to be caused by a regression with https://github.com/redhat-developer/vscode-extension-tester/releases/tag/v8.4.0 but more likely to be effect of switching vscode max version used for testing redhat-developer/vscode-extension-tester#1400

This should be treated as very important, as it might indicate even runtime problems with current version of vscode.

@ssbarnea ssbarnea added the bug Something isn't working label Jul 30, 2024
ssbarnea added a commit to alisonlhart/vscode-ansible that referenced this issue Aug 1, 2024
ssbarnea added a commit that referenced this issue Aug 1, 2024
ssbarnea added a commit that referenced this issue Aug 1, 2024
Related: #1464
Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
@alisonlhart
Copy link
Contributor

Possibly fixed in redhat-developer/vscode-extension-tester#1485, will verify.

@alisonlhart
Copy link
Contributor

The extester 8.6.0 release results in the same failure.
https://github.com/alisonlhart/vscode-ansible/actions/runs/10585584457/job/29332508066?pr=3#step:14:323
Adding an update on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants