-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng update @angular/cli
for custom builders
#24741
Comments
Hi, this is behaviour is intended by design. These 3rd party builders are not supported by the Angular team. Therefore it is the responsibility of the custom builder author to provide a migration as the Angular CLI does not know which options these builders provide, how they are used internally and how they interact together. If needed the migrations can be extended by the 3rd party author, this is already being done by other 3rd parties like NX. |
Hi @alan-agius4, thanks for clarification, i already reported this problem in just-jeb/angular-builders#1342 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Command
update
Is this a regression?
The previous version in which this bug was not present was
No response
Description
Currently if I use custom builders (such as
@angular-builders/custom-webpack
) doingng update @angular/cli
skips some updates (for version 15 it doesn't update main karma file). This is due to migration step which checks if builder target is@angular-devkit/build-angular:karma
. There should be a way to do migrations also for custom builders (which are using@angular-devkit/build-angular
with webpack and index.html customizations under the hood).At least i expect Angular migrations to work with community well known custom builders (such as
@angular-builders/custom-webpack
orngx-build-plus
), ideally it should work for any custom builders. Maybe migrations should not be checking only@angular-devkit/build-angular
builders?Minimal Reproduction
"builder": "@angular-builders/custom-webpack:karma",
for "test" architect inangular.json
fileng update @angular/cli
Exception or Error
Main karma file is not updated, but it should be updated.
Your Environment
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: