Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

After moving the splitter toggle to expand left column to maximum is not working #209

Open
saharj opened this issue May 7, 2016 · 8 comments

Comments

@saharj
Copy link

saharj commented May 7, 2016

Here is my HTML:

  <div ui-layout="{ flow : 'column', dividerSize: '8px'}">
    <div class="editor pane" ui-layout-container>
      <div ui-view="editor"></div>
    </div>
    <div class="preview pane" ui-layout-container>
      <div ui-view="preview"></div>
    </div>
  </div>

giphy

Surprisingly it does work for the right panel!

You can try it live at http://editor.swagger.io. You'll need to move the splitter a little before toggling to get the error.

@artigi
Copy link

artigi commented Jun 3, 2016

+1
The same happens in @widmoser's plunker in #162

@artigi
Copy link

artigi commented Jun 17, 2016

It looks like the Holy grail demo (ui-layout v1.0.5) doesn't have this issue.

@alagarrk
Copy link

In ui-layout v1.0.5, you will not get this issue and also it will not support ng-repeat.
You can try ui-layout v1.3.1 it will support both.

@umdstu
Copy link

umdstu commented Jun 30, 2016

Anyone take the time to see what the diff between the two versions (and subsequent versions) were that caused the break?

@dliu120
Copy link

dliu120 commented Aug 6, 2016

+1, this is breaking for me too, you can repro by just clicking on the different toggles several times. I This seems to be broken in 1.4.0, 1.4.1, and 1.4.2

I reverted back to 1.3.1 and it works

@bpatra
Copy link

bpatra commented Mar 15, 2017

Looks like someone found a solution here
Problem still open with 1.4.3.
Reproduction case demo/demo4.html with Chrome play a little with the toggle buttons and you will see the problem.
Looks like someone found a solution here (it is not me)
http://stackoverflow.com/questions/34310279/angular-ui-layout-toggle-not-working
I will PR this fix.

@zoyun
Copy link

zoyun commented Apr 13, 2017

+1

@zoyun
Copy link

zoyun commented Apr 13, 2017

calculate issue when the afterbutton click. the root cause due to do not update the uncollapsedSize of prevContainer when toggleAfter.
I have created a pull request for this bug fix. #228

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants