Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support roundtripping symbols with unknown text. #31

Open
tgregg opened this issue Dec 16, 2019 · 0 comments
Open

Support roundtripping symbols with unknown text. #31

tgregg opened this issue Dec 16, 2019 · 0 comments
Milestone

Comments

@tgregg
Copy link
Contributor

tgregg commented Dec 16, 2019

This is possible now that SymbolToken tracks ImportLocation. Two bits of logic are required:

  1. When the reader encounters a symbol ID that occurs within a shared symbol table but that shared symbol table is not resolved in the catalog, the reader should return a SymbolToken with null text and an ImportLocation that identifies the name and SID in the unresolved shared symbol table.
  2. When the writer is provided with a SymbolToken with null text and with a valid ImportLocation, it should calculate the local symbol ID from the import symbol ID and write the local symbol ID.
@tgregg tgregg added this to the Post-GA milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant