-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
behavior of global and constant device memory changed in develop branch #2305
Comments
Can we change the code to use the |
I am not sure if |
What do you mean by Are global variables implemented in the same way for all the accelerators that use the |
With #2242 we changed the behavior of global and constant device memory.
The new macro
ALPAKA_STATIC_ACC_MEM_GLOBAL
contains now a templateACC
, therefore we will get a unique type definition for each accelerator.A 1 dimensional acc has no access to the device global variable of the 2 dimensional acc. This was not the case in older alpaka versions.
This behavior change is most likely very easy to fix by adding a method to get the reference to the global memory. This method should use the device type derived from the accelerator to get the global memory. In this case all CPU accelerators will have access to the same memory address.
I marked this behavior change as bug and will try to address this issue after my vacations.
ping @AuroraPerego only that you know about it.
The text was updated successfully, but these errors were encountered: