Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define handling rules for <iframe> #31

Open
jemrobinson opened this issue Dec 13, 2018 · 2 comments
Open

Define handling rules for <iframe> #31

jemrobinson opened this issue Dec 13, 2018 · 2 comments
Labels
future Needs revisiting in the future

Comments

@jemrobinson
Copy link
Member

jemrobinson commented Dec 13, 2018 •
edited
Loading

How should <iframe> be dealt with? Should we attempt to retrieve the contents? If so, when in the process?
@jemrobinson
Copy link
Member Author

Note that the default BeautifulSoup behaviour is to not parse anything inside an <iframe>. Here is a minimal example taken from the failing code in #37.

> print(str(BeautifulSoup("<iframe><span></span></iframe>")))
> <html><head></head><body><iframe>&lt;span&gt;&lt;/span&gt;</iframe></body></html>

@jemrobinson
Copy link
Member Author

Easiest solution here is to blacklist iframe. Can revisit this in the future.

@jemrobinson jemrobinson mentioned this issue Dec 20, 2018
Merged
@jemrobinson jemrobinson added the future Needs revisiting in the future label Jan 8, 2019
@jemrobinson jemrobinson changed the title How should <iframe> be dealt with? Define handling rules for <iframe> Jan 11, 2019
@martintoreilly martintoreilly mentioned this issue Feb 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future Needs revisiting in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jemrobinson