Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unittests for ScoringEventHandler. #1353

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

add unittests for ScoringEventHandler. #1353

wants to merge 1 commit into from

Conversation

ernstleierzopf
Copy link
Contributor

@ernstleierzopf ernstleierzopf commented Oct 28, 2024 •
edited
Loading

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Must haves

Fixes #1208

Submission specific

  • This PR introduces breaking changes
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Describe changes:

@ernstleierzopf
add EventSourceInterface to SlidingEventFrequencyDetector
bd0051c 
add unittests for ScoringEventHandler.
landauermax
landauermax approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@landauermax landauermax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ernstleierzopf ernstleierzopf changed the title add EventSourceInterface to SlidingEventFrequencyDetector add unittests for ScoringEventHandler. Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landauermax landauermax landauermax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create unittests for the ScoringEventHandler
2 participants
@ernstleierzopf @landauermax