-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamodb and sqlite are both supported as distinct features. #50
base: master
Are you sure you want to change the base?
Conversation
I hope I didn't make any mistake. I've never used github's UI to resolve conflicts before :/ Anyway, let me know. PS: I am not putting the "db_connection_string" string behind a feature gate because:
|
❤️ Just wanted to pop in and say thanks for this PR. Today I had trouble with the hosted tunnelto.dev service (502s for an extended period) and this branch got me a self-hosted version pretty quickly! |
Was there hesitation here on the vendor-agnostic storage option of sqlite? I was recently thinking that I've enjoyed being a paying subscriber long enough that I'd fork this sqlite branch and spin up an internally-hosted instance at my company, for employees to rely on (data privacy concerns with the public service). But in case the lack of movement here is a sign of other context I'm missing, I thought it was worth a quick comment. |
@agrinman any update? Let me know if I should bring this now fairly dated pull request up to date. |
A new pull request to celebrate the progress of tunnelto's code base!
Anyway, this is my sqlite support pull request again, but as you requested it is now a conditional feature and implements the proper traits in its own separate file.
As usual, thanks for being patient with this very amateur Rust dev.