Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions and basetag #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pm-gmr
Copy link

@pm-gmr pm-gmr commented Jan 11, 2024

Adds missing executable permissions for scripts and allows a custom BASETAG when using a different BASEIMAGE (e.g. ros:noetic).

Adds execution permissions to the scripts in the
repository. The source repsitory for this fork did
not set any permissions.
@accetto
Copy link
Owner

accetto commented Jan 17, 2024

Hello @pm-gmr ,
I want just to confirm, that I've noticed your PR. I appreciate it very much. However, I'll come to it later, because I'm pretty busy now.
Regards, accetto

@pm-gmr
Copy link
Author

pm-gmr commented Jan 18, 2024

Sure. No problem. I was trying to use a different base image (osrf/ros:noetic-desktop-full) and encountered this issue. Thought I'll contribute a fix. Merge/review as per your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants