-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] current-state
event: Change note
format
#15
Comments
In that case the backend could send all notes in a flat list yes, since as you say the author ID is anyway embedded in the notes. The current shape actually just mirrors the datastructure used internally by the backend (ie. I didn't put more thought into it), but changing it is no problem at all! |
wowawiwa
changed the title
current-state Event structure
May 18, 2020
current-state
event: Change note
format
Or we can have all normalized. |
wowawiwa
changed the title
[REFACTOR] May 26, 2020
current-state
event: Change note
formatcurrent-state
event: Change note
format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the
current-state
event includes the keynotes: {[clientId: string]: Note[]};
Suggestion:
notes: Note[]
The mapping from clientID isn't needed, as the author is inside the note already and we don't operate by clientID anyway in the frontend.
The text was updated successfully, but these errors were encountered: