Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-snmp should map to SPDX license Net-SNMP #3950

Open
elrayle opened this issue Oct 16, 2024 · 2 comments
Open

net-snmp should map to SPDX license Net-SNMP #3950

elrayle opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
bug license-review A license detection issue that needs review new and improved data

Comments

@elrayle
Copy link

elrayle commented Oct 16, 2024

Description

At LicenseDB and in https://scancode-licensedb.aboutcode.org/index.json, net-snmp maps to LicenseRef-scancode-net-snmp. It includes an other_spdx_license_keys with the expected SPDX license Net-SNMP.

Actual

Excerpt from https://scancode-licensedb.aboutcode.org/index.json,

{
    "license_key": "net-snmp",
    "category": "Permissive",
    "spdx_license_key": "LicenseRef-scancode-net-snmp",
    "other_spdx_license_keys": [
      "Net-SNMP"
    ],
    "is_exception": false,
    "is_deprecated": false,
    "json": "net-snmp.json",
    "yaml": "net-snmp.yml",
    "html": "net-snmp.html",
    "license": "net-snmp.LICENSE"
  },

Expected

Excerpt from https://scancode-licensedb.aboutcode.org/index.json,

{
    "license_key": "net-snmp",
    "category": "Permissive",
    "spdx_license_key": "Net-SNMP",
    "other_spdx_license_keys": [],
    "is_exception": false,
    "is_deprecated": false,
    "json": "net-snmp.json",
    "yaml": "net-snmp.yml",
    "html": "net-snmp.html",
    "license": "net-snmp.LICENSE"
  },
@pombredanne
Copy link
Contributor

Thanks for the report!
https://scancode-licensedb.aboutcode.org/net-snmp.html is actually something that was always weird and recently deprecated by SPDX.
@AyanSinhaMahapatra I see this commit of yours: fffc98f#diff-570e21e32815e1eef07671480675ef8b3758ba6e0d378c91b807dff9a7768bde

... and if you undo this, we would now need to keep "LicenseRef-scancode-net-snmp" under
"other_spdx_license_keys"

Also: moving this ScanCode-Toolkit which is where the change will happen.

@pombredanne pombredanne transferred this issue from aboutcode-org/scancode-licensedb Oct 16, 2024
@pombredanne pombredanne added bug new and improved data license-review A license detection issue that needs review labels Oct 16, 2024
@AyanSinhaMahapatra AyanSinhaMahapatra self-assigned this Oct 17, 2024
@AyanSinhaMahapatra
Copy link
Contributor

@elrayle Thanks for the report, this should be fixed indeed.

@pombredanne this seems to be a side-effect of our spdx update script for deprecated spdx licenses, I will also check if there are other licenses effected like this, and update the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug license-review A license detection issue that needs review new and improved data
Projects
None yet
Development

No branches or pull requests

3 participants