Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate uniqueness before doing the transform #541

Open
chinyeungli opened this issue Oct 12, 2023 · 1 comment
Open

Validate uniqueness before doing the transform #541

chinyeungli opened this issue Oct 12, 2023 · 1 comment
Assignees

Comments

@chinyeungli
Copy link
Contributor

There are cases that a renamed field is already in the input that is causing issue. For instance,

field_renamings:
        license_expression : 'Concluded License Expression'

If the input already the license_expression field (but it's an empty field), the Concluded License Expression was renamed to license_expression and then this license_expression field got replaced with the original empty license_expression field and therefore the output will contains the orignal empty's license_expression field instead of the value from the renamed Concluded License Expression.

The tool should alret user for the issue and ask user to fix it before doing the transform process

@chinyeungli chinyeungli self-assigned this Oct 12, 2023
@chinyeungli chinyeungli changed the title Validate unique before doing the transform Validate uniqueness before doing the transform Oct 12, 2023
@v-a14
Copy link

v-a14 commented Oct 25, 2023

I want to work on this issue, please assign me this.

@chinyeungli chinyeungli assigned v-a14 and unassigned chinyeungli Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants