evil-yank doesn't invoke minad/goggles

[azzamsa]

Hi.

It is defined here:

minemacs/modules/me-editor.el

Line 166 in 16db93a

(goggles-define yank yank yank-pop evil-yank evil-yank-line)

But it doesn't flash during evil-yank. However, it flashes during evil-delete.

Screencast.from.2023-06-21.12-46-15.trimmed.webm

Thanks!

[abougouffa]

Yep, I noticed this and I didn't manage to get it to work correctly!

[azzamsa]

Should we report upstream?

[abougouffa]

I think it is only related to evil! Don't know if it is intended for use with evil or not!

[azzamsa]

Will explore minad/goggles#8

[abougouffa]

If I remember correctly, I've used evil-goggles before and didn't get satisfied with the result. It was noticeably slow, and the default colors were too faded for my taste.

[azzamsa]

evil-goggles works fine for me. Use it for 2 days and I don't notice any slowdown. Maybe you can re-explore it.