Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [REGRESSION] Brightmaps don't load on DOOM and DOOM2 IWADS. They do still work on FREEDOOM IWADS. #2760

Open
1 task done
blackhand1001 opened this issue Oct 13, 2024 · 6 comments
Labels

Comments

@blackhand1001
Copy link

GZDoom version

4.12.2

Which game are you running with GZDoom?

Doom 2

What Operating System are you using?

Windows 11

Please describe your specific OS version

Windows 11 Pro 24H2

Relevant hardware info

14900KF - RTX 4090

Have you checked that no other similar issue already exists?

  • I have searched and not found similar issues.

A clear and concise description of what the bug is.

Brightmaps do not load when playing any of the ID Software IWADS. Freedoom based iwads load them correctly.

It occurs on 4.12.2 and newer. It works correctly on 4.11.3 so the regression occured between those builds.

Steps to reproduce the behaviour.

Explain how to reproduce

  1. Start a game using a DOOM, DOOM2, TNT or PLUTONIA IWAD
  2. Brightmaps will not be working.

Your configuration

No response

Provide a Log

No response

@coelckers
Copy link
Member

Works fine for me. Are you sure you haven't switched them off in the launcher window?

@blackhand1001
Copy link
Author

Works fine for me. Are you sure you haven't switched them off in the launcher window?

Yes the button is checked and the brightmaps.pk3 is loaded. The issue is the game does not make use of these bright maps. I suspect something is messed up with the iwad filtering for applying the gldefs etc.

@blackhand1001
Copy link
Author

I suspect it is this commit that broke it.

21acb9d

@Blue-Shadow
Copy link
Contributor

Just like Graf, it works for me, too. (Screenshot taken using 4.12.2)

Screenshot_Doom_20241014_105944

@blackhand1001
Copy link
Author

blackhand1001 commented Oct 14, 2024

Can you test it with this pk3.

https://drive.google.com/file/d/10rVAzHBBmaUM9mesNAelwmfKgBdBZOkn/view?usp=drivesdk

I believe the issue may be with wads that use the old legacy filter names like doom.doom2 instead of doom.id.doom2

@blackhand1001
Copy link
Author

Yup that's that was it broken. I edited that pk3 to use the new lump filter names and it works now. The old names are broken in the current builds so old mods that use the old filters will be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants