Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolving Logic for Upstream Watershed Boundary Given LINKNO/streamID #7

Open
4 tasks
ptomasula opened this issue Jul 23, 2024 · 1 comment
Open
4 tasks
Assignees
Labels
enhancement New feature or request

Comments

@ptomasula
Copy link
Contributor

Summary

With the modified nest set index now implemented (MSNI) (see #3), the next step is to develop logic to utilize the MSNI to rapidly delineate a watershed polygon given the LINKNO/streamID for a reach. Some of the logic for how to utilize the MNSI is provided in this section of the README file.

The task for this issue is to develop the delineation logic and return a single polygon representing the upstream watershed of a provided reach id (LINKNO/streamID)

Closure Criteria

  • Function developed for subsetting the network based on modified nest set index
  • Function to combining (dissolving) subset of basins into a single polygon
  • Tests developed to verify resultant polygon matches known result
  • Performance of logic has been tested and characterized
@ptomasula ptomasula added the enhancement New feature or request label Jul 23, 2024
@ptomasula ptomasula self-assigned this Jul 23, 2024
ptomasula added a commit that referenced this issue Jul 23, 2024
#7
Provides some draft implementation for delineation and dissolve algorithms with some characterization of performance. It also became apparent in testing naive dissolve algorithms that some sort of pre-dissolve for upstream polygons will be necessary to maintain decent performance for larger watersheds.
@ptomasula
Copy link
Contributor Author

In exploring performance for some of the dissolve logic, it seems likely that we will need to implement some sort of pre-dissolve layer to maintain an acceptable level of performance for larger watersheds. I'll open a new issue to for the development of that logic, though I do provide a draft implementation in 0ab4609.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant