Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Memory] Add unit-tests that check memory content using mock_deps storage #95

Open
CyberHoward opened this issue Jan 3, 2022 · 1 comment
Open

[Memory] Add unit-tests that check memory content using mock_deps storage #95

CyberHoward opened this issue Jan 3, 2022 · 1 comment
Assignees
@kerber0x

Comments

@CyberHoward
Copy link
Contributor

The unit tests written for the memory contract only check the return value of the update functions. Idealy we should double check the stored value in the deps.storage MockStorage object.
It also misses an unauthorized set_admin tests
@CyberHoward CyberHoward added this to the Oak Security Audit milestone Jan 3, 2022
@CyberHoward
Copy link
Contributor Author

Options:

  • Check if core tests exist for Storage
  • Do it with integration tests

@kerber0x kerber0x removed this from the Oak Security Audit milestone Jan 6, 2022
@0xFable 0xFable removed their assignment Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerber0x kerber0x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xFable @CyberHoward @kerber0x