-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue TodoMVC source maps include full path of author's machine #385
Labels
trivial change
A change that doesn't affect benchmark results
Comments
Oh, can we fix this before 3.0 release? |
rniwa
added
v3-blocker
trivial change
A change that doesn't affect benchmark results
labels
Feb 29, 2024
One can see the webpack config used by vue like this:
Here we clearly see that the absolute directory is used everywhere. I'm not sure which of these impacts the source map generation. |
Removing v3-blocker keyword since this doesn't need to block the release of Speedometer 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The source maps for Vue TodoMVC are using the full path instead of the relative path, causing fake file changes every time a new person builds it. E.g:
"\n\nimport exportComponent from \"/Users/thorstenk/Desktop/FlashDesignory/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n
to
"\n\nimport exportComponent from \"/home/issackjohn/issack/Speedometer/resources/todomvc/architecture-examples/vue/node_modules/vue-loader/dist/exportHelper.js\"\n
in #376.
The text was updated successfully, but these errors were encountered: