Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'session_delete' event not fired stable #4612

Open
FtyTw opened this issue Jun 13, 2024 · 2 comments
Open

'session_delete' event not fired stable #4612

FtyTw opened this issue Jun 13, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@FtyTw
Copy link

FtyTw commented Jun 13, 2024

Hi! Can't get stability in collaborating with @walletconnect/web3wallet events. After successful pairing, session proposal and session establishing I can't get 'session_delete' event while trying to disconnect from the connected resource.

package.json
...
"react-native": "^0.68.0",
"@walletconnect/core": "^2.10.2",
"@walletconnect/react-native-compat": "^2.13.2",
"@walletconnect/web3wallet": "^1.12.2",
"ethers": "^5.7.2",
"events": "^3.3.0",
"fast-text-encoding": "^1.0.6",
...

To Reproduce

  1. Pass the wcurl to pair method of the web3wallet uniswap used for tests
  2. Obtain session proposal
  3. Approve it
  4. Observe that uniswap confirm connection
  5. Observe that the application confirmed connection
  6. Press disconnect at the uniswap side (seems like provider.disconnect method used)

Expected behavior
'session_delete' triggered so I'm able to align the session state for UI

Additional context
Time after time session might not be published at the application side despite that uniswap connector confirms that everything is fine. TrustWallet app or Binance works just fine and getting the events no matter how much times session was established | disconnected.

All of the functionality provided according the wallet connect docs of walletkit

UPD. I'm getting the "failed to publish" error pretty often when trying to approve session + the process of approval is pretty long. I've tried to run both of your RN project examples and everything works just fine, so maybe I've missed something and some specifics of my project are might be a reason of WC slow performance? Appreciate for any help

@FtyTw FtyTw added the type: bug Something isn't working label Jun 13, 2024
Copy link

linear bot commented Jun 13, 2024

@FtyTw
Copy link
Author

FtyTw commented Jul 16, 2024

Can be closed, we're migrated to native modules (WalletConnect Kotlin && WalletConnectSwift) instead and everything started to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant