Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server API tests #114

Open
Azquelt opened this issue May 27, 2016 · 0 comments
Open

Refactor server API tests #114

Azquelt opened this issue May 27, 2016 · 0 comments

Comments

@Azquelt
Copy link
Member

Azquelt commented May 27, 2016

Most of our server API tests are in ApiTest and PermissionsTest. There are a few reasons we shouls spend a little time refactoring them:

  1. Since the work to ensure that non-logged in users cannot see unpublished assets the line between what should go in each test has become a bit blurred, meaning that it's harder to find where the test for a specific feature is located.
  2. Both test classes have become quite large and may benefit from being broken up
  3. The Permissions test is very exhaustive, running each test in 24 different combinations. This is probably overkill. We should run a small set of tests in this exhaustive form and run the rest in a smaller number of combinations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant