Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[posm]: Create a view only library specific to posm positions #171

Open
snreynolds opened this issue Jul 19, 2024 · 2 comments
Open

[posm]: Create a view only library specific to posm positions #171

snreynolds opened this issue Jul 19, 2024 · 2 comments
Labels
posm position manager

Comments

@snreynolds
Copy link
Member

snreynolds commented Jul 19, 2024

Component

Position Manager

Describe the suggested feature and problem it solves.

This library should use StateLibrary.sol but be specific to querying information about a tokenId's position and should abstract away most under-the-hood logic (like the tokenId is used as a salt)

WRT this issue, we should maybe consider implementing the mapping from tokenId => positionId so this lookup is easier.

Also consider adding view functions for calculating fee growth of a specific position.

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

@snreynolds snreynolds added the posm position manager label Jul 19, 2024
Copy link

linear bot commented Jul 19, 2024

@saucepoint
Copy link
Collaborator

saucepoint commented Aug 5, 2024

Decided to provide getters instead of extsload + library helpers because

  1. we arent as constrained by bytecode as PoolManager
  2. there's very little state on posm itself

partially closed with #270 where a getter was added to access liquidity

still need a view function for fee growth, which will be useful for integrators and clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
posm position manager
Projects
None yet
Development

No branches or pull requests

2 participants