-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Sync reverts when locked #883
Comments
I should be able to
This pattern was broken by #856; now
|
My recommendation is to revert #856. |
Full writeup is in the PR description: #885 |
I have a second solution in case |
I calculate that the gas impact of the newly necessary approve/transferFrom or extra transfer described in #885 for my project is between 8371 and 25292 for tokens DAI and WETH. |
I reproduce the impact statement here, which discusses who all is impacted and how. Impact: Additional transfersThis section describes example of the aforementioned scenario, where being able to Custodian Contract (CC)This contract custodies funds and is the ultimate counterparty performing the swap. Perhaps it is an ERC-4337 smart account. Perhaps it is a multisig. But for whatever reason it doesn't have support for the UniswapV4 callback. Swap Callback (SC)This contract has support for the UniswapV4 callback. Its logic might be shared between many CC or it may be specific to one CC. The swap with versatile
|
Describe the bug
Sync reverts when locked
Expected Behavior
Sync should work when locked
To Reproduce
call sync outside unlock
Additional context
broken by #856
The text was updated successfully, but these errors were encountered: