Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs IUniversalRouter#execute x ISwapRouter#swapExactInputSingle x IUniswapV3PoolActions#swap #357

Open
crzypatchwork opened this issue Aug 25, 2023 · 0 comments

Comments

@crzypatchwork
Copy link

crzypatchwork commented Aug 25, 2023

docs suggests you to use ISwapRouter swapExactInputSingle while on prod uniswap app uses Universal Router
https://docs.uniswap.org/contracts/v3/guides/swaps/single-swaps
https://docs.uniswap.org/contracts/v3/reference/periphery/interfaces/ISwapRouter

this v3 pool as an example also doesnt have such public method https://polygonscan.com/address/0x0f663c16dd7c65cf87edb9229464ca77aeea536b#writeContract

seems it would make sense to either have instructions on how to use universal router or https://docs.uniswap.org/contracts/v3/reference/core/interfaces/pool/IUniswapV3PoolActions#swap instead in such guide as nothing in these docs makes sense

@crzypatchwork crzypatchwork changed the title docs IUniversalRouter execute x ISwapRouter swapExactInputSingle docs IUniversalRouter#execute x ISwapRouter#swapExactInputSingle x IUniswapV3PoolActions#swap Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant