Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PinholeSPECTUB code uses global variables #1211

Closed
mastergari opened this issue Jun 2, 2023 · 0 comments · Fixed by #1212
Closed

PinholeSPECTUB code uses global variables #1211

mastergari opened this issue Jun 2, 2023 · 0 comments · Fixed by #1212

Comments

@mastergari
Copy link
Contributor

The underlying *PinholeSPECTUB* code uses the following global variables:

https://github.com/UCL/STIR/blob/43b674789ca0e8865b33aa2fcded5992c8f2ca4f/src/recon_buildblock/ProjMatrixByBinPinholeSPECTUB.cxx#LL86C1-L93C2

This creates problems when

  • creating 2 different matrices
  • trying to use openmp pragmas, as it probably doesn't know what to share.

The suggested solution is to change the global variables to class members as done with the SPECTUB code (see issue #1108 and fix #1169).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change PinholeSPECTUB global variables to class members mastergari/STIR
1 participant
@mastergari