From 9e946c0de83f882de2359b071a5405c89bd1999b Mon Sep 17 00:00:00 2001 From: Xianda Sun <5433119+sunxd3@users.noreply.github.com> Date: Thu, 17 Oct 2024 18:42:00 +0800 Subject: [PATCH] Update design_notes/interface_for_gibbs.md --- design_notes/interface_for_gibbs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/design_notes/interface_for_gibbs.md b/design_notes/interface_for_gibbs.md index 2cbdf1e..7ecb341 100644 --- a/design_notes/interface_for_gibbs.md +++ b/design_notes/interface_for_gibbs.md @@ -66,7 +66,7 @@ For situations where model-specific details are required to compute the log dens ### Regarding `AbstractPPL.condition` -While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in this PR would not be fully compatible. +While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in the PR above would not be fully compatible. ### Samplers Should Not Manage Variable Names