Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SemiSupCompletionModel do not flip back the output['inv_depths_rgbd'] #227

Open
chenjx1005 opened this issue Apr 20, 2022 · 1 comment

Comments

@chenjx1005
Copy link

Bug appears when I train SemiSupCompletionModel. The DEPTH_PP_GT metric is much worse than DEPTH_GT of my re-trained model.

I check the traning code. In

output = flip_output(output)
, I found if flip is True, you do flip back the output['inv_depths'] but not output['inv_depths_rgbd']. see:
def flip_output(output):
, 'inv_depths_rgbd' key in not in the fliter_dict. As a result, it causes the model can not handle fliped input.

@VitorGuizilini-TRI
Copy link
Collaborator

Thank you for pointing that out! And thank you for your PR, I will take a look and merge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants