Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Audio when Ensata Emulation Enabled #850

Closed
dlbuhtig4096 opened this issue Oct 19, 2024 · 4 comments · Fixed by #851
Closed

No Audio when Ensata Emulation Enabled #850

dlbuhtig4096 opened this issue Oct 19, 2024 · 4 comments · Fixed by #851

Comments

@dlbuhtig4096
Copy link

State your operating system:

Windows11

DesMuME version

nightly

Issue

Games output no audio when ensata emulation is enabled.
Once ensata is disabled, audio works again.

I am not sure if links are allowed here, as they are related to the Nintendo leak occurred in 2020 and GameFreak leak happening recently.

@zeromus
Copy link
Contributor

zeromus commented Oct 19, 2024

don't hold your breath for this to get fixed. The ensata protocol could be doing a million things. You guys with whatever test case you have need to go figure that stuff out on your own.

@dlbuhtig4096
Copy link
Author

dlbuhtig4096 commented Oct 20, 2024

I was just reporting it first.

Ensata has a debug register 0x04fff200 that is not emulated by DeSmuMe currently, which seems to be the option to enable and disable sound.
When Ensata emulation is enabled, the game writes 0x10 to 0x04fff200 and get 32 bits response from it. If it returns zero, then all sound would be disabled.

So here's the quick fix to this:

		{
			if(addrMasked == eng_3D_CLIPMTX_RESULT) return true;
			if(addrMasked == 0x04FFF000) return true;
			if(addrMasked == 0x04FFF010) return true;
			if(addrMasked == 0x04FFF200) return true;
		}
				case 0x04FFF200:
					return;
				case 0x04FFF200:
					return 1; // Or perhaps some ui option flag

I am not pretty sure if the register would be used for other purpose, but I haven't seen any other access than audio control so far.

@zeromus
Copy link
Contributor

zeromus commented Oct 20, 2024

great work. you're on track. do it on a fork and test it and send a PR

@dlbuhtig4096
Copy link
Author

dlbuhtig4096 commented Oct 20, 2024

Just tested and it should work.
Please check #851 and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants