Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrainWeb-single_slice_motion Displayed images are cropped before cropping #55

Open
DANAJK opened this issue Jun 7, 2020 · 4 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DANAJK
Copy link
Contributor

DANAJK commented Jun 7, 2020

Displayed images look the same after cropping - in fact the images before cropping are cropped for presentation! - bit confusing.

@DANAJK DANAJK added the enhancement New feature or request label Jun 7, 2020
@rijobro rijobro self-assigned this Jun 8, 2020
@KrisThielemans
Copy link
Member

@DANAJK is this still relevant? Maybe you could attempt a fix, if it is

@KrisThielemans KrisThielemans added this to the v3.3 milestone Apr 28, 2022
@DANAJK
Copy link
Contributor Author

DANAJK commented Apr 28, 2022

It looks like it is still there. When this line is called
subplot_([2,3,1],FDG_arr [100:-100, 100:-100],'FDG' ,cmap="hot")
FDG_arr will be (1,344,344) (I don't know how the above subplot copes without a squeeze of the first dimension).
Then the array is cropped to (1,150,150) in the code, and this is similar to taking indices 100 to 344-100 in the original FDG_arr so the figures will look similar before and after cropping.

Probably the easiest thing to do is remove the [100: -100, 100:-100] in the first subplot call.

@KrisThielemans
Copy link
Member

Is this resolved? If not, does it need to be before the school?

@DANAJK
Copy link
Contributor Author

DANAJK commented May 28, 2022

Resolving lead to the expand_dims fix for a new bug. Original aim of removing the [100:-100 … code was not implemented. Not essential, just for clarity.

@KrisThielemans KrisThielemans modified the milestones: v3.3, v3.5 Jan 19, 2023
@KrisThielemans KrisThielemans modified the milestones: v3.5, v3.6 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants