Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues when choose "Default to system" preference, system in dark theme #1288

Open
Geeyun-JY3 opened this issue Jan 10, 2021 · 4 comments
Labels
bug 🐛 Something isn't working

Comments

@Geeyun-JY3
Copy link

Geeyun-JY3 commented Jan 10, 2021

  • Browser: Cent Browser 4.3.9.248 (64-bit) (Chromium 86.0.4240.198), Chrome 87.0.4280.141 (Official Build) (64-bit)
  • Operating System: Windows 10 20H2 19042.685
  • Link to page with the issue: any issue (listing) page, https://github.com/notifications
  • Screenshot:
    • Inbox "All caught up!" picture is not styled properly:
      image
    • Labels are still the GitHub native dark theme style
@Geeyun-JY3 Geeyun-JY3 added the bug 🐛 Something isn't working label Jan 10, 2021
@Mottie
Copy link
Member

Mottie commented Jan 10, 2021

Hi @Geeyun-JY3!

Please make sure your style is up-to-date.

Also, I've noticed a difference between choosing GitHub's light vs dark theme. I prefer the light theme as a base for GitHub Dark

Light
2021-01-10 08_37_02-Notifications
Dark
2021-01-10 08_38_45-Notifications

@Geeyun-JY3
Copy link
Author

Please make sure your style is up-to-date.

Yes I am pretty sure.

When I choose "Light" or "Dark" in "Setting > Appearance > Theme", it looks the same as screenshots you have posted. But when I choose "Default to system", it really looks like this:
image

BTW, I am using WinDynamicDesktop to changes Windows 10 app theme based on the time of day. I don't know if it is related.

@the-j0k3r
Copy link
Member

BTW, I am using WinDynamicDesktop to changes Windows 10 app theme based on the time of day. I don't know if it is related.

BTW shouldn't you disable that and test, then youll know.

@Geeyun-JY3
Copy link
Author

BTW shouldn't you disable that and test, then youll know.

Tested. I manually changed the default app mode in "Setting > Personalization > Colors", from "Light" to "Dark", then I got the same result. It is not related to WinDynamicDesktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants