-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Native Dark Mode #1275
Comments
Did you have a collaboration with the GitHub team? Just curious. |
Nothing to do with us. |
Gists is are unstyled by dark mode. |
@the-j0k3r Lots of components are unstyled yet, but that's why it's still in "Beta". |
Official dark theme is more like Solarized Dark, so, we would still like to have a deep dark update for this. |
Personally I dislike the native dark theme, because it's too blue (12,17,23) compared to this theme's neutral black (24,24,24). |
Just pinning this for visibilty. I guess we will keep maintaining this style for at least a while because I personally can't stand GH's dark mode 😉 |
Perhaps it'd be worth mentioning the native dark theme in the readme as well? |
I hope you continue maintining this for those who choose not to have an account here. |
Definitely don't like their dark blue theme. This one is much nicer. |
Moreover, we can choose the syntax highlighting color with this theme :) |
Unsubcribed |
Will this theme eventually just act as a custom GitHub theme that only changes GitHub's 600+ CSS variables? This entire theme can now just be a few hundred lines of variables defined in one |
Not if we want to keep support for the other sites like docs,gist,status.github.com etc. and the numerous extensions that still lack a dark mode. |
Actually you can remove 90% of the generated CSS by simply replacing the CSS vars assignments and instead of colors for the OTHER site assign them CSS vars in generator not colors... I know for a fact that works I done the same this style does in less than 5K lines all in (only status isnt supported), however not using the generator used here. Would make this style sane again though, but it was easier for me to do it from scratch else the syntax themes work is not possible to do as this style currently is. As for the GH 600 vars, is a design choice GH took,, 2/3 only have different var names the colors remain the same. 5K lines all sites except GH status instead of 50K plus thats 95% trim. |
I'm not going to put any more time into such ventures. It works as-is and if GH decides to variablify their other sites, it will automatically adapt. |
I love the GitHub-Dark custom CSS because it does so much more than just a "dark theme." I love being able to have my console font in code blocks with a color scheme of my choice, for example. Please keep this project going; I love it! |
I think this theme is still superior to the native dark mode, especially the background! |
Well github just added the new Dark Dimmed. The background looks better than the other dark version |
Today, we got the GitHub native dark theme.
This stylus GitHub Dark theme has helped me always. I want to leave my big thanks for this awesome project!
The text was updated successfully, but these errors were encountered: