-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Codespaces #1215
Comments
I guess we could exclude it our the regex if it really looks that bad. Does it come with a built in dark theme? |
Codespaces is just VS Code in the browser, it's fully themeable just like the desktop version. @tomocrafter can correct me on this, but I believe what they're doing is opening a port from the VM to run their application through and it's being themed with GHD when it shouldn't be. |
Can someone with access to Codespaces test if replacing domain("githubusercontent.com") with regexp("^https?://(?:(?!codespaces).)*githubusercontent\\.com.*$") works? |
The regex is just a stop gap, via stylus you can ignore some pages anyway as I detailed above. |
If that random part of the hostname changes often, it would be a burden. |
There's 3 urls I'm seeing when using port forwarding. The first initiates authentication using the format The second is the auth redirect which uses The third url is the one that your application loads with. The subdomain for this one changes for each vm and forwarded port (if you forward 10 ports you get 10 different subdomains). These use the format Replacing both occurrences of |
Looks like it is now |
|
GitHub's new feature codespaces brings function to access to local server via
https://<randomized id>.apps.codespaces.githubusercontent.com/
. Therefore, We need to exclude it from apply list.https://<randomized id>.apps.codespaces.githubusercontent.com/
The text was updated successfully, but these errors were encountered: